search

kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

Run kubevirt lane with KUBEVIRT_PSA=true #58

Closed AlonaKaplan closed 1 year ago

AlonaKaplan commented 1 year ago

What this PR does / why we need it: To be able to run VMs on a namespace with restricted PSA policy, KubevirtSeccompProfile feature gate should be enabled and a new configuration needs to be enabled under .spec.configuration.seccompConfiguration

virtualMachineInstanceProfile:
   customProfile:
       localhostProfile: kubevirt/kubevirt.json

Reference: https://github.com/kubevirt/kubevirt/pull/8917

Special notes for your reviewer:

AlonaKaplan commented 1 year ago

The previous run failed, are the latest changes fixed it, or it can be a flake ?

Thanks

It failed to communicate with the webhook. IDK why it happened.

oshoval commented 1 year ago

The previous run failed, are the latest changes fixed it, or it can be a flake ? Thanks

It failed to communicate with the webhook. IDK why it happened.

sounds like an unrelated flake, saw in the past here and there, unless we see it more frequent

AlonaKaplan commented 1 year ago

/approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubesecondarydns/blob/main/OWNERS)~~ [AlonaKaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment