search

kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

Add a default A record for each VM #60

Closed dankenigsberg closed 1 year ago

dankenigsberg commented 1 year ago

What this PR does / why we need it: make vm.namespace. resolve to one of the VM-reported IP addresses. This may make it a bit easier to find the VM even if the user does not recall its interface names.

This intends to resolve https://issues.redhat.com/browse/CNV-30087

Special notes for your reviewer: I have not tested this PR yet, it probably does not build.

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign alonakaplan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubesecondarydns/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AlonaKaplan commented 1 year ago

This e2e can be extended - https://github.com/kubevirt/kubesecondarydns/blob/main/tests/vm_startup_test.go#L91 Unit test is missing.

AlonaKaplan commented 1 year ago

Thanks for the contribution:)

AlonaKaplan commented 1 year ago

Done in PR - https://github.com/kubevirt/kubesecondarydns/pull/65

dankenigsberg commented 1 year ago

Done in PR - #65

Thank you.