Closed dankenigsberg closed 1 year ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign alonakaplan for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
This e2e can be extended - https://github.com/kubevirt/kubesecondarydns/blob/main/tests/vm_startup_test.go#L91 Unit test is missing.
Thanks for the contribution:)
Done in PR - https://github.com/kubevirt/kubesecondarydns/pull/65
Done in PR - #65
Thank you.
What this PR does / why we need it: make vm.namespace. resolve to one of the VM-reported IP addresses. This may make it a bit easier to find the VM even if the user does not recall its interface names.
This intends to resolve https://issues.redhat.com/browse/CNV-30087
Special notes for your reviewer: I have not tested this PR yet, it probably does not build.