kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

kubevirtci: Bump kubevirtci #62

Closed oshoval closed 1 year ago

oshoval commented 1 year ago

What this PR does / why we need it:

Special notes for your reviewer: Latest (2309141019-029e67a) kubevirtci doesn't work [1] for now pinning newer than current meanwhile,

[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubesecondarydns/62/pull-kubesecondarydns-e2e-k8s/1703684178278617088

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign alonakaplan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubesecondarydns/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oshoval commented 1 year ago

/hold

it fails https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubesecondarydns/62/pull-kubesecondarydns-e2e-k8s/1703684178278617088

oshoval commented 1 year ago

will reopen once back to it

oshoval commented 1 year ago

/hold cancel

oshoval commented 1 year ago

/hold

hmm failed, (locally passed) prow is laggy today, will look later on why it failed (btw saw one time a flake also not on this PR, so maybe related)

oshoval commented 1 year ago

let see if 1.25 with 2306031446-398ee73 works on CI (worked locally) previous run with 1.27 and 2306031446-398ee73 didn't work on CI

oshoval commented 1 year ago

interesting, it pass with 1.25 on CI as well (assuming not a flake) lets try again

/test pull-kubesecondarydns-e2e-k8s

oshoval commented 1 year ago

worth first to check current hash on main with 1.27 as we see that 1.27 doesnt work on bump, while 1.25 is