search

kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

Add a default A record for each VM #65

Closed AlonaKaplan closed 11 months ago

AlonaKaplan commented 11 months ago

make vm.namespace.<cluster>. resolve to one of the VM-reported IP addresses. This may make it a bit easier to find the VM even if the user does not recall its interface names.

What this PR does / why we need it: make vm.namespace.<cluster>. resolve to one of the VM-reported IP addresses. This may make it a bit easier to find the VM even if the user does not recall its interface names.

This intends to resolve https://issues.redhat.com/browse/CNV-30087

Special notes for your reviewer: Finalizing PR https://github.com/kubevirt/kubesecondarydns/pull/60

AlonaKaplan commented 11 months ago

Thanks

Worth to describe please the the FQDN includes cluster_name vm.namespace.<cluster_name>. (as mentioned on ticket / done by tests)

Describe where? It is written in the PR description - "make vm.namespace. resolve to one of the VM-reported IP addresses. "

oshoval commented 11 months ago

Thanks Worth to describe please the the FQDN includes cluster_name vm.namespace.<cluster_name>. (as mentioned on ticket / done by tests)

Describe where? It is written in the PR description - "make vm.namespace. resolve to one of the VM-reported IP addresses. "

In the PR desc itself please, just to add there that should be part of the query (PR desc atm doesn't mention as part of the query) Unless the servers have a suffix with cluster_name it won't find it. Even the tests include it.

oshoval commented 11 months ago

/test pull-kubesecondarydns-e2e-k8s

failure not relevant Error response from daemon: cannot listen on the TCP port: listen tcp4 :34873: bind: address already in use we might want to try another random port when it creates the sockets

AlonaKaplan commented 11 months ago

/approve

kubevirt-bot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubesecondarydns/blob/main/OWNERS)~~ [AlonaKaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment