search

kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

feat: add snyk file to exclude vendor folders #67

Closed oshoval closed 11 months ago

oshoval commented 11 months ago

What this PR does / why we need it: This file is used for snyk integration to config snyk scan.

Special notes for your reviewer:

phoracek commented 11 months ago

@oshoval would we still get an alert if our dependencies contain CVEs?

oshoval commented 11 months ago

@oshoval would we still get an alert if our dependencies contain CVEs?

Yes, this is for excluding the vendor folder during Code analysis Packages analyzing is done via go.mod, not via Code analysis on vendor folder

See please https://github.com/kubevirt/ssp-operator/pull/706

phoracek commented 11 months ago

Understood. Thanks!

AlonaKaplan commented 11 months ago

/lgtm /approve

kubevirt-bot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubesecondarydns/blob/main/OWNERS)~~ [AlonaKaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment