fix kubevirt-web-ui tag when docker_tag is configured

kubevirt / kubevirt-ansible

Set of Ansible roles & playbooks for KubeVirt deployment

Apache License 2.0

91 stars 72 forks source link

fix kubevirt-web-ui tag when docker_tag is configured #535

Closed SchSeba closed 5 years ago

SchSeba commented 5 years ago

What this PR does / why we need it: This PR remove the "v" character from the set_fact: kubevirt_web_ui_image_tag

This PR also fix the deprovision of kubevirt. when we check the kubevirt namespace oc get ns | grep -w 'kubevirt' kubevirt Active 1d kubevirt-web-ui Active 1h

check the command to be oc get ns | grep 'kubevirt ' (space added)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

None

This change is

SchSeba commented 5 years ago

@cynepco3hahue can you please take a look :)

SchSeba commented 5 years ago

the Failed look unrelated. https://jenkins.ovirt.org/job/kubevirt_kubevirt-ansible_standard-check-pr/2116//artifact/check-patch.openshift_3-11.el7.x86_64/mock_logs/script/stdout_stderr.log

SchSeba commented 5 years ago

ci test please

SchSeba commented 5 years ago

ci test please

myakove commented 5 years ago

LGTM

cynepco3hahue commented 5 years ago

ci test please

cynepco3hahue commented 5 years ago

hm Sanity test fails, possible that it starts test before all components are running.

SchSeba commented 5 years ago

I try to add a sleep before integration tests start. lets check if this fix the issue

SchSeba commented 5 years ago

for reference

TASK [kubevirt : Download KubeVirt Template] ***********************************
Monday 07 January 2019  13:20:32 +0000 (0:00:00.219)       0:32:40.912 ******** 
fatal: [localhost]: FAILED! => {
    "changed": false, 
    "dest": "/home/jenkins/workspace/kubevirt_kubevirt-ansible_standard-check-pr/kubevirt-ansible/roles/kubevirt/templates/kubevirt.yaml.j2", 
    "state": "absent", 
    "url": "https://github.com/kubevirt/kubevirt/releases/download/v0.12.0-alpha.2/kubevirt.yaml.j2"
}

MSG:

Connection failure: ('The read operation timed out',)

This looks unrelated to this PR I will rerun the tests

SchSeba commented 5 years ago

ci test please

SchSeba commented 5 years ago

@gbenhaim can you help me here with the ci? I don't think the fail is related to this PR For reference https://jenkins.ovirt.org/job/kubevirt_kubevirt-ansible_standard-check-pr/2125/artifact/ci_build_summary.html

SchSeba commented 5 years ago

ci test please

marchukov commented 5 years ago

ci test please

petrkotas commented 5 years ago

ci test please

SchSeba commented 5 years ago

The tests pass now Can we merge it @cynepco3hahue?