Closed phoracek closed 5 years ago
@SchSeba @booxter please take a look
ci test please
@phoracek BTW we'll need to backport it to release-0.12 branch.
@SchSeba @booxter @myakove is there a simple way how to test the PR locally? The last run failed again "Failed to start SRIOV DP".
And now I noticed, the init container uses hard-coded fedora:29... we need to replace it with a template variable.
LGTM
After I changed the base image, it failed with:
Jan 23 12:13:32 lago-node0 origin-node: E0123 12:13:32.936234 10022 pod_workers.go:186] Error syncing pod 89474911-1f31-11e9-9b20-5452c0a8c802 ("kube-sriov-device-plugin-amd64-npk5v_kube-system(89474911-1f31-11e9-9b20-5452c0a8c802)"), skipping: failed to "StartContainer" for "config-container" with CreateContainerError: "container create failed: container_linux.go:336: starting container process caused \"exec: \\\"/bin/bash\\\": stat /bin/bash: no such file or directory\"\n"
Going to use sh.
ci test please
The failure seems to be a spurious functional test failure, not deployment issue anymore.
facepalm this is painful
ci test please
Again, it did not fail on deployment but on some later test, trying to retrigger to see whether we can get green.
https://jenkins.ovirt.org/job/kubevirt_kubevirt-ansible_standard-check-pr/2303/consoleFull
@lukas-bednar would you please take a look? It seems like the deployment passed, but then it timed out or something, probably unrelated. Thanks
@phoracek I don't have an access to std-ci slaves, you might to need ask @gbenhaim .
I already saw this RBAC failure time to time on other jobs too ... lets try to retest it ...
ci test please
ci test please
please please please
@lukas-bednar so, we got green from CI, but we have to rebase :grimacing:
@rthallisey @lukas-bednar can you merge this now?
For reference https://jenkins.ovirt.org/job/kubevirt_kubevirt-ansible_standard-check-pr/2328/artifact/ci_build_summary.html
I pretty sure this issue is unrelated to this PR
ci test please
Hi @rthallisey @lukas-bednar I think you merge this now?
@phoracek can you rebase? Then we can merge
@rthallisey @lukas-bednar passed CI, could you please merge?
In commit 5ebfa70d035fbb5a409bc243cb5319e136fe0a77, SR-IOV config distribution code was placed in CNI manifest by mistake. Because of that, SR-IOV DP restart does not updade SR-IOV config file.