search

kubevirt / kubevirt-ansible

Set of Ansible roles & playbooks for KubeVirt deployment
Apache License 2.0
91 stars 72 forks source link

Deprovision sriov resources #592

Closed booxter closed 5 years ago

booxter commented 5 years ago

What this PR does / why we need it: delete SR-IOV resources on deprovisioning. The only piece that is not cleaned up is /etc/pcidp because I don't know how to do it easily without running a new container that would delete the directory, on all cluster nodes, which seems like overkill.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE
booxter commented 5 years ago

ci test please

booxter commented 5 years ago

@rthallisey @phoracek @SchSeba could you please review? Thanks.

rthallisey commented 5 years ago

@booxter if we don't cleanup /etc/pcidp on all nodes will it be an issue on redeploy?

booxter commented 5 years ago

@rthallisey it shouldn't be an issue on redeploy. We override an existing file via configmap.