kubevirt / kubevirt-ansible

Set of Ansible roles & playbooks for KubeVirt deployment
Apache License 2.0
91 stars 72 forks source link

Aligning registry variable in kubevirt-cpu-node-labeller to global standard #597

Closed dcritch closed 5 years ago

dcritch commented 5 years ago

At a global level, the registry_url and registry_namespace variables can be overridden in the event that you are using an internal/private registry. The kubevirt-cpu-node-labeller uses its own unique value for the namespace, so currently an additional variable (repo_tag) to control the registry. This change aligns it with the standard.

What this PR does / why we need it: This PR updates the kubevirt-cpu-node-labeller role to use the global registry_namespace variable, rather than its own unique one.

Change repo_tag variable to registry_namespace in the kubevirt-cpu-node-labeller role to match global variables.
action required: If a user was overriding the registry namespace for an install, they no longer have to additionally override the 'repo_tag' variable in their variables file.