search

kubevirt / kubevirt-ansible

Set of Ansible roles & playbooks for KubeVirt deployment
Apache License 2.0
91 stars 72 forks source link

Ignore failing on firewalld #625

Closed iranzo closed 4 years ago

iranzo commented 4 years ago

Earlier today, my scripts to deploy a kubernetes env via this repository started to fail with no other change in our code, complaining line was ansible about firewalld service (which was stopped and disabled)

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

Do not fail on firewalld errors
iranzo commented 4 years ago

As a contributor on this file, can you @alexxa , @gbenhaim and @gouyang help me understand what failed in the CI check of this?

Thanks Pablo

kubevirt-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

iranzo commented 4 years ago

/remove-lifecycle stale

iranzo commented 4 years ago

/recheck

kubevirt-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten