search

kubevirt / kubevirt-tekton-tasks

VM specific tasks for Tekton Pipelines
Apache License 2.0
31 stars 34 forks source link

feat: add timeout parameter to modify-data-object task #548

Closed ksimon1 closed 2 weeks ago

ksimon1 commented 2 weeks ago

What this PR does / why we need it: feat: add timeout parameter to modify-data-object tasks

When importing data object from slow server and wait-for-success param is set to true, one hour of timeout might not be enough. This commit introduces new parameter timeout where user can increase / decrease time necessary to import data object. Defaul value is 1 hour.

Release note:

feat: add timeout parameter to modify-data-object tasks
kubevirt-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubevirt-tekton-tasks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codingben commented 2 weeks ago

@ksimon1 Can you please take a look on the failure? I see this error [1]:

Error from server (BadRequest): error when creating "modify-data-object.yaml": admission webhook "validation.webhook.pipeline.tekton.dev" denied the request: validation failed: non-existent variable in "$(params.timout)": spec.steps[0].env[TIMEOUT]

It seems like you have typo: $(params.timout)

[1] https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/kubevirt_kubevirt-tekton-tasks/548/pull-ci-kubevirt-kubevirt-tekton-tasks-main-e2e-tests/1854115697370599424

ksimon1 commented 2 weeks ago

/retest

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix, codingben, ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt-tekton-tasks/blob/main/OWNERS)~~ [0xFelix,ksimon1] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment