search

kubevirt / kubevirt-tekton-tasks

VM specific tasks for Tekton Pipelines
Apache License 2.0
31 stars 34 forks source link

fix(CNV-40411): wrong export source kinds #555

Closed codingben closed 5 days ago

codingben commented 5 days ago

What this PR does / why we need it:

There is a check of the export source kind before getting labels from the export source. It expects kinds "VirutalMachine", "VirtualMachineSnapshot" or only "PersistentVolumeClaim". Instead, it should be "vm", "vmsnapshot" or only "pvc".

Release note:

None
kubevirt-bot commented 5 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign 0xfelix for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubevirt-tekton-tasks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: codingben Once this PR has been reviewed and has the lgtm label, please assign 0xfelix for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubevirt-tekton-tasks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 days ago

@codingben: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/win10-pipeline-example-test 53a62f2f89a75e66f737ff0eab620241680a4371 link true /test win10-pipeline-example-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).