search

kubevirt / kubevirt-tutorial

Demo that guides users through an end to end KubeVirt experience.
https://www.kubevirt.io/
Apache License 2.0
31 stars 28 forks source link

Fix multus setup #102

Closed scheeles closed 5 years ago

scheeles commented 5 years ago

The VMs are searching in the default NS instead of the kubevirt also for VM I correct the multus resource name

kubevirt-bot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: codificat

If they are not already assigned, you can assign the PR to them by writing /assign @codificat in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubevirt-tutorial/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codificat commented 5 years ago

Thanks for the PR. However, these errors you found are actually there on purpose... there is a warning at the top of lab 8 that mentions that the lab contains errors - the ones you are reporting here.

The idea behind this is to help make sure that students review the files they are working with.

If you think this is confusing or shouldn't be there we can apply the fix - but I would also remove that warking from the lab at the same time.

@scheeles @slintes @fabiand what do you think?

Until we agree on the best way forward let's /hold

slintes commented 5 years ago

I liked it, it's a nice little exercise for debugging not starting VMs

scheeles commented 5 years ago

Agree I like it as well. I now now how to fix it ;-)