search

kubevirt / kubevirt-tutorial

Demo that guides users through an end to end KubeVirt experience.
https://www.kubevirt.io/
Apache License 2.0
31 stars 28 forks source link

Enable nested before deploying #110

Closed iranzo closed 5 years ago

kubevirt-bot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign iranzo You can assign the PR to them by writing /assign @iranzo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubevirt-tutorial/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
iranzo commented 5 years ago

/cc ptrnull /kind enhancement

iranzo commented 5 years ago

/retest

codificat commented 5 years ago

Do we need this? AFAIK we've been able to spin VMs just fine with nested virt so far - which should perform quite better than emulation.

The environment setup code includes enabling nested virt.

iranzo commented 5 years ago

This is to test the failure in CI in #108 to see if the timeout in lab4 happens because of vm spin as the commit in that PR should have nothing to do at all with infra failing, but it does

iranzo commented 5 years ago

If this test passes, means that nested is 'now' needed for another reason and might, via merge, enable us to pass 108 and merge it

codificat commented 5 years ago

I see... however, if CI is broken let's rather fix the CI, no?

My understanding is that with this change the labs would run slower, right?

kubevirt-bot commented 5 years ago

@iranzo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubevirt-tutorial-presubmit-lab-testing-k8s-1.13.3 a1dfccfd81f314b4421513bcb658a380d058ec62 link /test kubevirt-tutorial-presubmit-lab-testing-k8s-1.13.3
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).