kubevirt / kubevirt-velero-plugin

Plugin to Velero which automates backing up and restoring KubeVirt/CDI objects
Apache License 2.0
29 stars 28 forks source link

Test framework for evaluating if a backup integration works properly #128

Closed ShellyKa13 closed 1 year ago

ShellyKa13 commented 1 year ago

What this PR does / why we need it: The PR improved tests framework by handling namespace creation and deletion in the general test framework instead in each test context. Handle clients creation better. Create yaml that can be used also for other backup/restore providers to test if their tools integrates properly with kubevirt. Adjust test to consume this yaml to make sure the yamls will not go old an outdated without notice. Add some more test for backup and restore.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

Add yamls to be used to make sure backup integration works properly
ShellyKa13 commented 1 year ago

@mhenriks Thanks! I checked and there are several standalone VMI tests which I can convert to also consume yamls and create appropriate yamls. Regarding VMIRS I understand its missing need to also add relevant backup/restore action items so it will be done in different PR. Same for GC, I am working on adjusting all the tests to work both with and without GC. will be on different PR.

ShellyKa13 commented 1 year ago

fixed @akalenyu comments. Converted the positive standalone VMI test to consume yaml like @mhenriks asked. GC and VMIRS will be in different PRs.

mhenriks commented 1 year ago

Great work @ShellyKa13!

/lgtm /approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt-velero-plugin/blob/main/OWNERS)~~ [mhenriks] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment