search

kubevirt / kubevirt-velero-plugin

Plugin to Velero which automates backing up and restoring KubeVirt/CDI objects
Apache License 2.0
25 stars 28 forks source link

Test and env updates #208

Closed ShellyKa13 closed 5 months ago

ShellyKa13 commented 6 months ago

What this PR does / why we need it: This change is a first step in trying to make our tests usable to test compatibility with kubevirt for other backup partners. This change marks tests that apply example manifests with label PartnerComp. This allows to run only those tests with gingko filter: make TEST_ARGS="--test-args=-ginkgo.label-filter=PartnerComp" test-functional Also those yamls were hardcoded with a storageclass, now changed the framework in order to make it possible to config other SC by updating env variable KVP_STORAGE_CLASS To apply the yamls manually you'll need to replace the placeholder {{KVP_STORAGE_CLASS}} with your desired storageclass or run it with a replace command such as: cat tests/manifests/vm_with_pvc.yaml | sed 's/{{KVP_STORAGE_CLASS}}/rook-ceph-block/g' | kubectl create -f -

Updated kubevirtci due to a bug in the last version of a problem running with docker.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

Add PartnerComp label
mhenriks commented 6 months ago

@ShellyKa13 Can you edit the PR description to briefly state reasoning for changes to to tests/manifests?

mhenriks commented 5 months ago

/lgtm /approve

kubevirt-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt-velero-plugin/blob/main/OWNERS)~~ [mhenriks] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ShellyKa13 commented 5 months ago

/cherrypick release-0.6

kubevirt-bot commented 5 months ago

@ShellyKa13: cannot checkout release-0.6: error checking out "release-0.6": exit status 1 error: pathspec 'release-0.6' did not match any file(s) known to git

In response to [this](https://github.com/kubevirt/kubevirt-velero-plugin/pull/208#issuecomment-1927345545): >/cherrypick release-0.6 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ShellyKa13 commented 5 months ago

/cherrypick release-v0.6

kubevirt-bot commented 5 months ago

@ShellyKa13: new pull request created: #220

In response to [this](https://github.com/kubevirt/kubevirt-velero-plugin/pull/208#issuecomment-1929080850): >/cherrypick release-v0.6 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.