search

kubevirt / kubevirt-velero-plugin

Plugin to Velero which automates backing up and restoring KubeVirt/CDI objects
Apache License 2.0
26 stars 26 forks source link

Generalize problematic tests #212

Closed ShellyKa13 closed 4 months ago

ShellyKa13 commented 5 months ago

What this PR does / why we need it: Generalize tests to check for specific resources in backup

Instead of expecting a specific number of objects backed up
we should check if the objects we care about were backed up,
the check can also catch bugs that we could have missed in case
the number didnt change but for some reason our desired object
wasnt backed up.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

Fix problematic tests
mhenriks commented 5 months ago

I think you are going to want to rebase this

mhenriks commented 4 months ago

/lgtm /approve

kubevirt-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt-velero-plugin/blob/main/OWNERS)~~ [mhenriks] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mhenriks commented 4 months ago

/cherrypick release-v0.6

kubevirt-bot commented 4 months ago

@mhenriks: new pull request created: #222

In response to [this](https://github.com/kubevirt/kubevirt-velero-plugin/pull/212#issuecomment-1942631858): >/cherrypick release-v0.6 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.