kubevirt / kubevirt-velero-plugin

Plugin to Velero which automates backing up and restoring KubeVirt/CDI objects
Apache License 2.0
26 stars 26 forks source link

Get rid of busybox dockerhub image usage in tests #231

Closed akalenyu closed 3 months ago

akalenyu commented 3 months ago

What this PR does / why we need it: DockerHub is rate limiting, so at some point pulling this will simply fail.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE
ShellyKa13 commented 3 months ago

/lgtm Ill just say that it would have been easier to see what actually changed if you first did the change, and then in a separate commit just move the function :)

mhenriks commented 3 months ago

/approve

kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt-velero-plugin/blob/main/OWNERS)~~ [mhenriks] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment