Fix test issues + increase number of nodes in the cluster

ShellyKa13 commented 2 months ago

What this PR does / why we need it: We have seen several test issues when running with more then 1 nodes. This PR fixes those issues and increase the number of nodes running in the CI to better catch this issues. Changes:

Fixed pod security and arranged pod related functionallities (should solve failures in test 9864)
Fixed issue in test 10191. jira-ticket: https://issues.redhat.com/browse/CNV-39913
Remove debug code that causes timeouts d/s when the test fails there.
Update instancetype and preferences manifests version since alpha is deprecated and will be removed soon

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes # test 9864 and 10191 d/s

Special notes for your reviewer:

Release note:

Create cluster with 2 nodes

mhenriks commented 2 months ago

/lgtm /approve

ShellyKa13 commented 2 months ago

/hold Changed number of nodes in the cluster, I want to run several times to see its stable

kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels, mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt-velero-plugin/blob/main/OWNERS)~~ [awels,mhenriks] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ShellyKa13 commented 2 months ago

/unhold

ShellyKa13 commented 2 months ago

/cherrypick release-v0.6

kubevirt-bot commented 2 months ago

@ShellyKa13: #241 failed to apply on top of branch "release-v0.6":

Applying: Update version of instancetype and prefernce yamls to use beta instead of alpha
Applying: Move start of vm to after writer pod succeeded
Applying: Gather all pod related functions in one place
Using index info to reconstruct a base tree...
M   tests/framework/storage.go
M   tests/resource_filtering_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/resource_filtering_test.go
Auto-merging tests/framework/storage.go
CONFLICT (content): Merge conflict in tests/framework/storage.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Gather all pod related functions in one place
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to [this](https://github.com/kubevirt/kubevirt-velero-plugin/pull/241#issuecomment-2088077227): >/cherrypick release-v0.6 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

kubevirt / kubevirt-velero-plugin

Fix test issues + increase number of nodes in the cluster #241