search

kubevirt / kubevirt-velero-plugin

Plugin to Velero which automates backing up and restoring KubeVirt/CDI objects
Apache License 2.0
26 stars 26 forks source link

Bump velero library and deployment to 1.14 + go update and kubevirtci #249

Closed ShellyKa13 closed 2 weeks ago

ShellyKa13 commented 1 month ago

Release note:

Update velero to 1.14 and go to 1.22.3
akalenyu commented 1 month ago

So I don't fully understand it yet but somehow the .gitignore directive for velero* introduced in https://github.com/kubevirt/kubevirt-velero-plugin/pull/208/commits/71c67b4ea7918955eee34ee8e9b2dd92784909d1 is dropping some critical additions in the velero vendored dir

$ git status  
On branch bump-velero
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   .gitignore

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        vendor/github.com/vmware-tanzu/velero/pkg/apis/velero/shared/
        vendor/github.com/vmware-tanzu/velero/pkg/cmd/util/flag/orlabelselector.go
        vendor/github.com/vmware-tanzu/velero/pkg/features/verify.go
        vendor/github.com/vmware-tanzu/velero/pkg/plugin/framework/common/plugin_config.go

no changes added to commit (use "git add" and/or "git commit -a")

I guess existing vendor files stayed put, but new ones were never added?

ShellyKa13 commented 3 weeks ago

/test pull-kvp-functional-test

ShellyKa13 commented 3 weeks ago

/test pull-kvp-functional-test

ShellyKa13 commented 2 weeks ago

/retest

ShellyKa13 commented 2 weeks ago

/retest

ShellyKa13 commented 2 weeks ago

/test pull-kvp-functional-test

alromeros commented 2 weeks ago

Looks good, nice commit separation /lgtm

ShellyKa13 commented 2 weeks ago

/approve

kubevirt-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ShellyKa13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt-velero-plugin/blob/main/OWNERS)~~ [ShellyKa13] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment