Restore fails after label-based backup due to missing instancetype `ControllerRevision`

[e3b0c442]

What happened: When attempting to restore a backed-up VM, the restore fails with an error similar to the following: error restoring virtualmachines.kubevirt.io/vms/one: admission webhook "virtualmachine-validator.kubevirt.io" denied the request: Failure to find instancetype: controllerrevisions.apps "node1-o1.large-3ae509a7-5446-4119-945d-1eb2a00d00cb-1" not found

What you expected to happen: The ControllerRevision is correctly backed up with the VM when a label is specified, and the restore completes successfully.

How to reproduce it (as minimally and precisely as possible):

1. Create a VM with a VirtualMachineClusterInstanceType or VirtualMachineInstanceType and an identifying label
2. Back up the VM with Velero, specifying the label. e.g. velero backup create node1-backup --include-namespaces vms -l name=node1 --snapshot-move-data --wait
3. Delete the backed-up VM kubectl delete vm node1
4. Attempt to restore the VM velero restore create --from-backup node1-backup

Additional context: When specifying a label filter, the ControllerRevision resource is not added to the backup, despite being owned by the VirtualMachine resource. Labels applied to the VirtualMachine resource are not propagated down to the ControllerRevision created by KubeVirt.

If the label filter is removed and the entire namespace is backed up, the ControllerRevision resource is included in the backups and subsequently restored successfully..

Environment:

• KubeVirt version (use virtctl version):

  Client Version: version.Info{GitVersion:"1.2.2", GitCommit:"$Format:%H$", GitTreeState:"", BuildDate:"1970-01-01T00:00:00Z", GoVersion:"go1.22.4", Compiler:"gc", Platform:"darwin/arm64"}
  Server Version: version.Info{GitVersion:"v1.2.2", GitCommit:"1466b658f78b9b8bb9517ffb6dafd4b777f33fe6", GitTreeState:"clean", BuildDate:"2024-06-06T05:46:26Z", GoVersion:"go1.21.8 X:nocoverageredesign", Compiler:"gc", Platform:"linux/amd64"}

• Kubernetes version (use kubectl version): N/A

  Client Version: v1.30.2
  Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
  Server Version: v1.29.6

• VM or VMI specifications: N/A

  apiVersion: kubevirt.io/v1
  kind: VirtualMachine
  metadata:
  name: one
  namespace: vms
  labels:
  vms.e3b0c442.dev/name: one
  spec:
  dataVolumeTemplates:
  - metadata:
      namespace: vms
      name: one-rootdisk
      labels:
        vms.e3b0c442.dev/name: one
    spec:
      pvc:
        accessModes:
          - ReadWriteMany
        resources:
          requests:
            storage: 40Gi
        volumeMode: Block
        storageClassName: ceph-block
      source:
        pvc:
          namespace: vms
          name: fedora-40-amd64
  instancetype:
  name: o1.large
  preference:
  name: fedora
  runStrategy: Always
  template:
  metadata:
    labels:
      vms.e3b0c442.dev/naem: one
  spec:
    domain:
      cpu:
        model: Westmere
      devices:
        disks:
          - name: rootdisk
          - name: cloudinitdisk
        interfaces:
          - name: multus
            macAddress: 02:e3:b0:00:00:01
            bridge: {}
    networks:
      - name: multus
        multus:
          networkName: vms/vlan-176
    evictionStrategy: LiveMigrate
    terminationGracePeriodSeconds: 0
    volumes:
      - dataVolume:
          name: one-rootdisk
        name: rootdisk
      - cloudInitNoCloud:
          userData: |-
            #cloud-config
            users:
              - name: nick
                groups: wheel
                passwd: REDACTED
                lock_passwd: false
                ssh_authorized_keys:
                  - ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAILG8LVJNXtypT9BARc1NKKB4E0mMZB4nIjSeoeNYufJo
            growpart:
              mode: auto
        name: cloudinitdisk

• Cloud provider or hardware configuration: various bare metal
• OS (e.g. from /etc/os-release):

  NAME="Talos"
  ID=talos
  VERSION_ID=v1.7.5
  PRETTY_NAME="Talos (v1.7.5)"
  HOME_URL="https://www.talos.dev/"
  BUG_REPORT_URL="https://github.com/siderolabs/talos/issues"
  VENDOR_NAME="Sidero Labs"
  VENDOR_URL="https://www.siderolabs.com/"

• Kernel (e.g. uname -a): Linux node-agent-debug 6.6.33-talos #1 SMP Tue Jun 18 14:02:42 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
• Install tools: talosctl
• Others: N/A