search

kubevirt / kubevirt-velero-plugin

Plugin to Velero which automates backing up and restoring KubeVirt/CDI objects
Apache License 2.0
29 stars 28 forks source link

Support VirtualMachineClusterInstancetype and VirtualMachineClusterPreference #261

Closed mhenriks closed 1 month ago

mhenriks commented 1 month ago

What this PR does / why we need it:

Support VirtualMachineClusterInstancetype and VirtualMachineClusterpreference

Also better support namespaced versions by doing case insensitive check of vm.spec.instancetype|preference.kind

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #258

Special notes for your reviewer:

Release note:

Support VirtualMachineClusterInstancetype and VirtualMachineClusterPreference
kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ShellyKa13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt-velero-plugin/blob/main/OWNERS)~~ [ShellyKa13] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ShellyKa13 commented 1 month ago

/lgtm

ShellyKa13 commented 2 weeks ago

/cherrypick release-v0.7

kubevirt-bot commented 2 weeks ago

@ShellyKa13: new pull request created: #274

In response to [this](https://github.com/kubevirt/kubevirt-velero-plugin/pull/261#issuecomment-2295202468): >/cherrypick release-v0.7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.