search

kubevirt / kubevirt-velero-plugin

Plugin to Velero which automates backing up and restoring KubeVirt/CDI objects
Apache License 2.0
32 stars 28 forks source link

Simplify KUBECONFIG for tests #40

Closed brybacki closed 2 years ago

brybacki commented 2 years ago

What this PR does / why we need it: makes it possible to run func tests without running make cluster-up

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE
akalenyu commented 2 years ago

/lgtm

brybacki commented 2 years ago

/approve

mhenriks commented 2 years ago

/lgtm /approve

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brybacki, mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt-velero-plugin/blob/main/OWNERS)~~ [brybacki,mhenriks] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
brybacki commented 2 years ago

this only changes ENV variable, tests are running so it is good /override pull-kvp-functional-test

kubevirt-bot commented 2 years ago

@brybacki: Overrode contexts on behalf of brybacki: pull-kvp-functional-test

In response to [this](https://github.com/kubevirt/kubevirt-velero-plugin/pull/40#issuecomment-1064170667): >this only changes ENV variable, tests are running so it is good >/override pull-kvp-functional-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.