search

kubevirt / kubevirt-velero-plugin

Plugin to Velero which automates backing up and restoring KubeVirt/CDI objects
Apache License 2.0
32 stars 28 forks source link

Handle DV that is in progress #66

Closed brybacki closed 2 years ago

brybacki commented 2 years ago

What this PR does / why we need it:

When the "not finished DataVolume" is stored in backup it should restore correctly and CDI shoud retry the DV action to finish it. DataVolume is stored as is, without applying "PrePopulated" annotation. The PVC for this DV is stored and marked InProgress, then it is not restored (skipped).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Currently it is not possible to skip a PVC during backup.

Release note:

Handle DV that is in progress
mhenriks commented 2 years ago

/lgtm /approve

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt-velero-plugin/blob/main/OWNERS)~~ [mhenriks] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment