search

kubevirt / kubevirt-velero-plugin

Plugin to Velero which automates backing up and restoring KubeVirt/CDI objects
Apache License 2.0
29 stars 28 forks source link

Support virtual machine snapshot during backup to perform quiesced VM backup #70

Closed kamlad closed 1 year ago

kamlad commented 2 years ago

Is this a BUG REPORT or FEATURE REQUEST?:

kind enhancement

What happened:

Looking at documentation and code, it doesn't look like velero kubevirt plugin performs kubevirt VirtualMachineSnapshot before backup

What you expected to happen:

Perform virtual machine snapshot , and then use the snapshots as source of backup

How to reproduce it (as minimally and precisely as possible):

Backup

Anything else we need to know?:

Environment:

brybacki commented 2 years ago

Hi @kamlad, thank you for the issue.

I am not sure it is the goal of the plugin, Can you elaborate on this? Can you provide some more information on the issue. Describe why is it useful or better than current form of backup?

I think that the goal of backup is to have a way to restore you VM after a disaster. To have your disks restored and VM restarted.

kubevirt-bot commented 1 year ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot commented 1 year ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubevirt-bot commented 1 year ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubevirt-bot commented 1 year ago

@kubevirt-bot: Closing this issue.

In response to [this](https://github.com/kubevirt/kubevirt-velero-plugin/issues/70#issuecomment-1318704265): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.