search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 115 forks source link

Fix labs-description: Remove localhost:24000 from hrefs #626

Closed haslersn closed 4 years ago

haslersn commented 4 years ago

Fixes #625

kubevirt-bot commented 4 years ago

Hi @haslersn. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mazzystr commented 4 years ago

Please do a dummy commit using git commit -s -a -m blah then rebase and squash into a single commit. We have to have that signed-by... message in the commit log in order to pass CI

/C

On Tue, Sep 15, 2020, 8:41 PM haslersn notifications@github.com wrote:

Fixes #625 https://github.com/kubevirt/kubevirt.github.io/issues/625

You can view, comment on, or merge this pull request online at:

https://github.com/kubevirt/kubevirt.github.io/pull/626 Commit Summary

  • Fix labs-description: Remove localhost:24000 from hrefs

File Changes

Patch Links:

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/kubevirt/kubevirt.github.io/pull/626, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS5KZ4SF7HTJPFL24NFGWDSGAXX3ANCNFSM4ROE6XLQ .

haslersn commented 4 years ago

I did the following and hope that's enough.

git commit --amend -s -a --no-e
git push -f
mazzystr commented 4 years ago

/lgtm /approve

kubevirt-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mazzystr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/source/OWNERS)~~ [mazzystr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment