Attaching to multiple networks followup 2

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/

https://kubevirt.io

MIT License

30 stars 115 forks source link

Attaching to multiple networks followup 2 #638

Closed qinqon closed 4 years ago

qinqon commented 4 years ago

What this PR does / why we need it: Multiple Network Attachment with bridge CNI (#631)

Add blog port post to do follow up on multi network connectivity blog post but this time with bridge CNI instead of OVS, cluster-network-addons-operator to install all the kubevirt network operators and kubernetes-nmstate to configure the bridge at nodes.

It also install jekyll-diagrams [1]

[1] https://github.com/zhustec/jekyll-diagrams

Does this PR fix any issue? _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_:

Fixes #

Special notes for your reviewer: Depends on https://github.com/kubevirt/kubevirt.github.io/pull/637

qinqon commented 4 years ago

@maiqueb I haven't being able to make prettier the pre-commit hook to ignore it, this is not working https://prettier.io/docs/en/ignore.html#range-ignore

qinqon commented 4 years ago

Pushed:

Addressed Radim and Ram comments
Fixed set-context issue with deploy.sh from HCO
Pod network binding set to masquerade since it's the default binding configured at HCO if no interface is specified.

qinqon commented 4 years ago

Push:

Fixed VMs interface output now that MAC address comes from kubemacpool.

qinqon commented 4 years ago

Push:

Addressed Ram's comments

RamLavi commented 4 years ago

/lgtm

qinqon commented 4 years ago

Adressed Radim's comments.

qinqon commented 4 years ago

Adressed Petr's comments.

rhrazdil commented 4 years ago

@qinqon Looks good to me

qinqon commented 4 years ago

@codificat moved it to news

phoracek commented 4 years ago

/lgtm

Thanks, awesome!

qinqon commented 4 years ago

push: Addressed @codificat comments, diff https://github.com/kubevirt/kubevirt.github.io/compare/f2c197f81ab409f221b36fa4c79f4d647548f4f1..afbab64a87a9a4dffb3587158000105ea4372c9d

codificat commented 4 years ago

Great, thanks! /approve

kubevirt-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/source/OWNERS)~~ [codificat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codificat commented 4 years ago

oh, and /lgtm