search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 115 forks source link

Make the popup video auto-play when open #647

Closed codificat closed 4 years ago

codificat commented 4 years ago

What this PR does / why we need it:

This change makes the "KubeVirt overview" video in the home page start to play as soon as it pops up.

Currently to view the video you need 2 clicks. With that, it's just 1 click.

Does this PR fix any issue? _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_:

Fixes #

Special notes for your reviewer:

mazzystr commented 4 years ago

Ah. I misunderstood. I thought it was an embedded video with autoplay upon page render which would be about as good as a flash presentation.

Yes, This is good!

/lgtm /approved

mazzystr commented 4 years ago

/approve

kubevirt-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mazzystr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/source/OWNERS)~~ [mazzystr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment