search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 115 forks source link

Correct commit with signiture for pull/450 and https://github.com/ira… #649

Closed mazzystr closed 3 years ago

mazzystr commented 4 years ago

What this PR does / why we need it: Getting this content into a mergeable state

See ...

codificat commented 4 years ago

I think I'm missing something here: I don't see much of a difference in content between this PR and #450 .

Can you elaborate on the reason behind this PR? (vs #450)

mazzystr commented 3 years ago

@codificat There is no difference. I messed up pull 450 trying to amend the commit msg and get DCO to pass. iranzo is no longer available to resubmit. So I forked his branch and recreated the pull.

codificat commented 3 years ago

/lgtm /approve

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/source/OWNERS)~~ [codificat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment