search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 112 forks source link

adding linter checks to Makefile #719

Closed eifrach closed 3 years ago

eifrach commented 3 years ago

Signed-off-by: Eran Ifrach eifrach@redhat.com+

**What this PR does :

Fixes #652

eifrach commented 3 years ago

/hold

kubevirt-bot commented 3 years ago

Hi @eifrach. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign mazzystr You can assign the PR to them by writing /assign @mazzystr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/source/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mazzystr commented 3 years ago

/ok-to-test

mazzystr commented 3 years ago

And another 302 link failure...

6:46:33 AM: - ./_site/2018/Deploying-KubeVirt-on-a-Single-oVirt-VM.html
6:46:33 AM:   *  External link https://docs.okd.io/1.5/install_config/install/host_preparation.html#configuring-docker-storage failed: 301 Number of redirects hit maximum amount
eifrach commented 3 years ago

closing this PR -- the fix it added in PR #725