Update lab2 for latest minikube

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/

https://kubevirt.io

MIT License

30 stars 112 forks source link

Update lab2 for latest minikube #723

Closed cwilkers closed 3 years ago

cwilkers commented 3 years ago

Remove storage-setup.yml and its references
Alter pvc_fedora.yml to remove storageclass
Download pvc_fedora.yml locally to use it later
Add commands to delete and recreate pvc if needed
Alter instructions to excise mention of hostpath-provisioner
Updated to use minikube ip instead of status

Fixes #695

kubevirt-bot commented 3 years ago

Hi @cwilkers. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

cwilkers commented 3 years ago

re-pushed to get around spell check not liking "Minikube's"

mazzystr commented 3 years ago

@cwilkers You're gonna have to add a commit to fix the following links...

- ./_site/2019/prow-jobs-for-kubevirt.html

  *  External link https://github.com/kubevirt/project-infra/blob/master/github/ci/prow/files/jobs/kubevirt/kubevirt-tutorial/kubevirt-tutorial-presubmits.yaml failed: 404 No error

- ./_site/summit/index.html

  *  External link https://github.com/nunnatsa%E2%80%8B failed: 404 No error

mazzystr commented 3 years ago

Very good! Looking better yet! /approve /lgtm

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mazzystr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/source/OWNERS)~~ [mazzystr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment