search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 112 forks source link

new container for local testing #725

Closed eifrach closed 3 years ago

eifrach commented 3 years ago

What this PR does / why we need it:

Fixes #715 #652

kubevirt-bot commented 3 years ago

Hi @eifrach. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
eifrach commented 3 years ago

waiting for a merge on different repo /hold

/assign @mmazur

mazzystr commented 3 years ago

@eifrach This is an XL pull req that at the heart is fatally broken. Jekyll runtime has changed and the app is no longer accessible.

I really think we're trying to take on too much here. Near as I can tell we have 3 items going on ... Add linting, consolidate build, update dictionary.

I highly suggest these items be broken out into smaller pull reqs.

mazzystr commented 3 years ago

/retest all

kubevirt-bot commented 3 years ago

@mazzystr: The /retest command does not accept any targets. The following commands are available to trigger jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubevirt/kubevirt.github.io/pull/725#issuecomment-821538477): >/retest all Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mazzystr commented 3 years ago

/test all

kubevirt-bot commented 3 years ago

@eifrach: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubevirt-io-presubmit-link-checker e62c485dfb668992f7bfbe7aa6c84ded0968e497 link /test kubevirt-io-presubmit-link-checker
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mazzystr commented 3 years ago

@.** can you add that Dockerfile to the pull req to project-infra? I didn't have a copy so wasn't able to do it on Fri

On Sun, Apr 18, 2021, 2:35 AM Eran Ifrach @.***> wrote:

@.**** commented on this pull request.

In Makefile https://github.com/kubevirt/kubevirt.github.io/pull/725#discussion_r615371218 :

@echo
  • @echo "${GREEN}Makefile: Check links and selectors to userguide on website content${RESET}"

  • +## Stop site +stop: | envvar

  • @echo "${GREEN}Makefile: Stop site${RESET}"
  • ${CONTAINER_ENGINE} rm -f website 2> /dev/null; echo
  • @echo -n

  • +## Build image localhost/kubevirt.io +build_image: | envvar

  • ${DEBUG}$(eval export TAG='localhost/kubevirt.io')
  • @echo "${GREEN}Makefile: Cloneing Repo ${RESET}"
  • ${DEBUG}git clone https://github.com/kubevirt/project-infra.git /tmp/project-infra; \

@mazzystr https://github.com/mazzystr This Dockerfile needs all the files in the directory. what you are suggesting we do take a look the the repo folder

https://github.com/eifrach/project-infra/tree/kubevirt.io/images/kubevirt-kubevirt.github.io

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubevirt/kubevirt.github.io/pull/725#discussion_r615371218, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS5KZ4NS4JRKAOOZQAWA4DTJKRW3ANCNFSM42ZNILQQ .

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from mazzystr after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/source/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 3 years ago

@eifrach: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubevirt/kubevirt.github.io/pull/725#pullrequestreview-638313887): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 3 years ago

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
eifrach commented 3 years ago

Closing PR reopening in a new branch