search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 112 forks source link

add new continer to Makefile #731

Closed eifrach closed 3 years ago

eifrach commented 3 years ago

Signed-off-by: Eran Ifrach eifrach@redhat.com

What this PR does :

Fixes #715

kubevirt-bot commented 3 years ago

Hi @eifrach. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
eifrach commented 3 years ago

/assign @mazzystr

mazzystr commented 3 years ago

/ok-to-test

mazzystr commented 3 years ago

@eifrach This is a much cleaner pull req. Thanks for recreating it.

Since we're changing the way the Makefile works we need to update the README.md to reflect those changes. Please add a commit for that.

Then all there is just a few minor changes that need fixed.

More on L161 .... I'm gonna insist that the old script get put back. I had to do locally in order to test make check_spelling since otherwise I can't test until the CI team takes a look and merges pull/115. In the future if we want to expand the script we have to check it in to project repo ... then test here. That's a pretty bad dependency. We also have to bolt on additional script functions such as | and || to get around file system permissions and give a problem notice to the user. We're in the exact same spot as before with additional complexity and risk.

If you put the old script back we can merge this pretty quick when the minors get fixed.

We can talk about consolidating all the file retrieve code in another issue/pull_req.

eifrach commented 3 years ago

@mazzystr all changes has been added

cwilkers commented 3 years ago

Working now, examples:

$ make run ; podman logs -f website

Makefile: Stop running container
podman rm -f website 2> /dev/null; echo

Makefile: Run site
for i in .jekyll-cache _site Gemfile.lock; do rm -rf ./"${i}" 2> /dev/null; echo -n; done
podman run -d --name website --net=host -v /home/cwilkers/git/kubevirt.github.io:/srv:ro,Z -v /dev/null:/srv/Gemfile.lock:rw,Z --mount type=tmpfs,destination=/srv/_site --mount type=tmpfs,destination=/srv/.jekyll-cache --workdir=/srv localhost/kubevirt-kubevirt.github.io /bin/bash -c "jekyll serve --host=0.0.0.0 --trace --force_polling --future"
623f97604b8ee0f082a7d193ba3e3fe1104ec7b9435b72a5f79aac512b616808

--- Log output truncated ---

                    done in 3.934 seconds.
 Auto-regeneration: enabled for '/srv'
    Server address: http://0.0.0.0:4000/
  Server running... press ctrl-c to stop.
$ make check_links

--- Output clipped ---

Checks html files for broken external links (This can take a few mins to run) ...
Running ["ScriptCheck", "LinkCheck", "ImageCheck"] on ["./_site"] on *.html... 

Checking 1091 external links...
Ran on 366 files!

HTML-Proofer finished successfully.

Checks html files for broken internal links (This can take a few mins to run) ...
Running ["ScriptCheck", "LinkCheck", "ImageCheck"] on ["./_site"] on *.html... 

Ran on 366 files!

HTML-Proofer finished successfully.

--- Output clipped ---

$ make check_spelling

Makefile: Stop running container
podman rm -f website 2> /dev/null; echo
623f97604b8ee0f082a7d193ba3e3fe1104ec7b9435b72a5f79aac512b616808

Makefile: Check spelling on site content
YASPELLER file: ./yaspeller.json
Be sure to add changes to upstream: kubevirt/project-infra/master/images/yaspeller/.yaspeller.json

Spelling check:
✗ ./README.md 408 ms
-----
--- Output clipped ---
mazzystr commented 3 years ago

/test kubevirt-io-presubmit-link-checker

mazzystr commented 3 years ago

/lgtm /approve

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mazzystr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/source/OWNERS)~~ [mazzystr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment