search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 112 forks source link

Update description field for 2021-04-30-intel-vgpu-kubevirt blog post #734

Closed xphyr closed 3 years ago

xphyr commented 3 years ago

What this PR does / why we need it:

Fixes an oversight in the blog post where I left the "example" description for the blog post in place. Current description does not look good on blog post listing page.

Fixes #711

kubevirt-bot commented 3 years ago

Hi @xphyr. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mazzystr commented 3 years ago

/lgtm Approve

On Sat, May 1, 2021, 7:38 AM kubevirt-bot @.***> wrote:

Hi @xphyr https://github.com/xphyr. Thanks for your PR.

I'm waiting for a kubevirt https://github.com/orgs/kubevirt/people member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org https://github.com/orgs/kubevirt/people to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here https://go.k8s.io/bot-commands?repo=kubevirt%2Fkubevirt.github.io.

Instructions for interacting with me using PR comments are available here https://git.k8s.io/community/contributors/guide/pull-requests.md. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue: repository.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kubevirt/kubevirt.github.io/pull/734#issuecomment-830642951, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS5KZ32Y2TEB4I4K5YXOVTTLQG7TANCNFSM436MKAZQ .

mazzystr commented 3 years ago

/ok-to-test

On Sat, May 1, 2021, 7:38 AM Mark D @.***> wrote:

What this PR does / why we need it:

Fixes an oversight in the blog post where I left the "example" description for the blog post in place. Current description does not look good on blog post listing page.

You can view, comment on, or merge this pull request online at:

https://github.com/kubevirt/kubevirt.github.io/pull/734 Commit Summary

  • Update 2021-04-30-intel-vgpu-kubevirt.md

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kubevirt/kubevirt.github.io/pull/734, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS5KZZLX7WQ3FRIZ7L3NZ3TLQG7BANCNFSM436MKAZQ .

mazzystr commented 3 years ago

/approve

On Sat, May 1, 2021, 7:38 AM Mark D @.***> wrote:

What this PR does / why we need it:

Fixes an oversight in the blog post where I left the "example" description for the blog post in place. Current description does not look good on blog post listing page.

You can view, comment on, or merge this pull request online at:

https://github.com/kubevirt/kubevirt.github.io/pull/734 Commit Summary

  • Update 2021-04-30-intel-vgpu-kubevirt.md

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kubevirt/kubevirt.github.io/pull/734, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS5KZZLX7WQ3FRIZ7L3NZ3TLQG7BANCNFSM436MKAZQ .

mazzystr commented 3 years ago

/approved

mazzystr commented 3 years ago

@xphyr you're finally merged

xphyr commented 3 years ago

Ok thanks. Fyi @mazzystr it does not appear to have updated the site itself. The site still shows 'excerpt of the blog post' or something like that

mazzystr commented 3 years ago

@xphyr Can you post a screenshot so I can see what you're seeing?

The code in master branch looks correct to me.... https://github.com/kubevirt/kubevirt.github.io/blob/master/2021/intel-vgpu-kubevirt.html#L38

The rendered and served code looks correct to me.... Web browse to https://kubevirt.io/2021/intel-vgpu-kubevirt.html Open up dev tools Web browser word search for "Description" .... Again I see the Description patch

xphyr commented 3 years ago

Looks good now. Must have taken some time to populate. Thanks again!

mazzystr commented 3 years ago

Whew! Good to hear!

It also looks like we have an auto publishing problem for future dated blog posts. Thanks for bringing that to our attention. We will be working on it on the back end.