Closed mazzystr closed 3 years ago
@davidvossel Sorry to bug ya. We gotta get this right in order to leave travis-ci.
/lgtm
check_spelling with an error returns Error 2
@cwilkers: changing LGTM is restricted to collaborators
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: davidvossel, mazzystr
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it: FIXES #742
Special notes for your reviewer: Run
make check_spelling
1) Initial test should fail with many spell checks.echo $?
should return 2 which will be the same as the Makefile error 2) Update Line159 and invalidate url.echo $?
should return 2 which will be the same as the Makefile error 3) Update Line159 and invalidate filename.echo $?
should return 2 which will be the same as the Makefile error 4) Update local yaspeller,json file with errors from above (this is gonna be painful ...) and thenrm -rf ./README.md
.make check_spelling
should complete successfully.echo $?
should return 0.