kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 112 forks source link

Fix check_spelling exit codes plus a couple cosmetics #743

Closed mazzystr closed 3 years ago

mazzystr commented 3 years ago

What this PR does / why we need it: FIXES #742

Special notes for your reviewer: Run make check_spelling 1) Initial test should fail with many spell checks. echo $? should return 2 which will be the same as the Makefile error 2) Update Line159 and invalidate url. echo $? should return 2 which will be the same as the Makefile error 3) Update Line159 and invalidate filename. echo $? should return 2 which will be the same as the Makefile error 4) Update local yaspeller,json file with errors from above (this is gonna be painful ...) and then rm -rf ./README.md. make check_spelling should complete successfully. echo $? should return 0.

mazzystr commented 3 years ago

@davidvossel Sorry to bug ya. We gotta get this right in order to leave travis-ci.

cwilkers commented 3 years ago

/lgtm

check_spelling with an error returns Error 2

kubevirt-bot commented 3 years ago

@cwilkers: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubevirt/kubevirt.github.io/pull/743#issuecomment-857193461): >/lgtm > >check_spelling with an error returns Error 2 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mazzystr commented 3 years ago

/approve

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, mazzystr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/source/OWNERS)~~ [davidvossel,mazzystr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment