Closed mazzystr closed 3 years ago
I can confirm the PR works as expected, a bad link prints Error 1, (make returns 2) and on no bad links, make returns 0.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: davidvossel
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
What this PR does / why we need it: Fix check_spelling exit codes, speed plus cosmetics
Does this PR fix any issue?: Fixes #730 Fixes #744
Special notes for your reviewer:
Check for success
make check_links
echo $?
Check for link failure
sed -i s/node_assignment/sdfsdf/g _posts/*Advanced-scheduling-with-affinity-rules*
make check_links
HTML-Proofer found 1 failure!
File: ./_site/2020/Advanced-scheduling-with-affinity-rules.html Link: https://kubevirt.io/user-guide/operations/node_assignment/#sdfsdf Test file: /src/check_selectors.js
type: assertExists
file: /src/check_selectors.js
subject: false
selector: "#sdfsdf"
FAIL 1 test executed in 1.132s, 0 passed, 1 failed, 0 dubious, 0 skipped.
Details for the 1 failed test:
In /src/check_selectors.js file: ./_site/2020/Advanced-scheduling-with-affinity-rules.html, url: https://kubevirt.io/user-guide/operations/node_assignment/#sdfsdf assertExists: Find selector: #sdfsdf make: *** [Makefile:130: check_links] Error 2