kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 112 forks source link

Fix check_spelling exit codes, speed plus cosmetics #745

Closed mazzystr closed 3 years ago

mazzystr commented 3 years ago

What this PR does / why we need it: Fix check_spelling exit codes, speed plus cosmetics

Does this PR fix any issue?: Fixes #730 Fixes #744

Special notes for your reviewer:

Check for success

Check for link failure

HTML-Proofer found 1 failure!

* Run `echo $?`
  * Output should be 1

### Check for selector failure
* Run `git checkout _posts/*Advanced-scheduling-with-affinity-rules*`
* Run `sed -i s/affinity-and-anti-affinity/sdfsdf/g _posts/*Advanced-scheduling-with-affinity-rules*`
* Run `make check_links`
  * Output should be ...

File: ./_site/2020/Advanced-scheduling-with-affinity-rules.html Link: https://kubevirt.io/user-guide/operations/node_assignment/#sdfsdf Test file: /src/check_selectors.js

type: assertExists

file: /src/check_selectors.js

subject: false

selector: "#sdfsdf"

FAIL 1 test executed in 1.132s, 0 passed, 1 failed, 0 dubious, 0 skipped.

Details for the 1 failed test:

In /src/check_selectors.js file: ./_site/2020/Advanced-scheduling-with-affinity-rules.html, url: https://kubevirt.io/user-guide/operations/node_assignment/#sdfsdf assertExists: Find selector: #sdfsdf make: *** [Makefile:130: check_links] Error 2


* Run `echo $?`
  * Output should be 2
cwilkers commented 3 years ago

I can confirm the PR works as expected, a bad link prints Error 1, (make returns 2) and on no bad links, make returns 0.

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/source/OWNERS)~~ [davidvossel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
davidvossel commented 3 years ago

/lgtm