Closed cwilkers closed 3 years ago
Hi @cwilkers. Thanks for your PR.
I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
Following a conversation on the kubevirt-dev mailing list, I am considering including labs/manifests/vm.yaml in this PR, changing its network style to masquerade, and re-using this yaml for this PR rather than duplicating it in a code scriptlet.
Everything looks great! We're rolling!
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mazzystr
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Fixed #759
Fixed #760
Signed-off-by: cwilkers cwilkers@redhat.com