search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 112 forks source link

Fix lint errors #767

Closed tylerauerbeck closed 3 years ago

tylerauerbeck commented 3 years ago

Signed-off-by: Tyler Auerbeck tauerbec@redhat.com

What this PR does / why we need it:

This PR will fix the initial lint errors found by make check_lint

Does this PR fix any issue? _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_:

Fixes #766

Special notes for your reviewer:

Starting this off as a draft as it will likely grow quite large.

kubevirt-bot commented 3 years ago

Hi @tylerauerbeck. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dhiller commented 3 years ago

/test all

dhiller commented 3 years ago

@tylerauerbeck I'll be offline for a while now, so to be fair, I'll remove myself from the reviewers list.

tylerauerbeck commented 3 years ago

This should be ready now. There are a handful of lint rules that I had disabled for now and I added two _includes files to the .markdownlintignore file as there are conflicts with how they get included vs lint rules that you would want in place in other files. But otherwise, this is just a bunch of fixes to correct the lint errors.

cwilkers commented 3 years ago

/approve

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwilkers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/master/OWNERS)~~ [cwilkers] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mazzystr commented 3 years ago

@tylerauerbeck Wow! Thanks for this clean up effort!