search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 112 forks source link

Added yaml file for migration lab that uses masquerade n/w #773

Closed ansijain closed 3 years ago

ansijain commented 3 years ago

Signed-off-by: ansijain ansi.jain@india.nec.com

What this PR does / why we need it: Added yaml file for migration lab that uses masquerade n/w instead of bridge Also updated the migration lab with new yaml file

Does this PR fix any issue? _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_:

Fixes https://github.com/kubevirt/kubevirt.github.io/issues/772

Special notes for your reviewer:

kubevirt-bot commented 3 years ago

Hi @ansijain. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cwilkers commented 3 years ago

/ok-to-test @ansijain Thank you for your PR and for catching the issue with masquerade versus bridge. I had meant to alter vm.yaml to switch it over to masquerade, but apparently my change didn't make it into my PR somehow. (I previously thought it was a CI issue, but just checked the file's blame log, and cannot find my change)

Since you caught this, would you be okay with altering your PR to flip the network type in vm.yaml? Would you see any reason not to start with a masquerade network type in lab1?

ansijain commented 3 years ago

/ok-to-test @ansijain Thank you for your PR and for catching the issue with masquerade versus bridge. I had meant to alter vm.yaml to switch it over to masquerade, but apparently my change didn't make it into my PR somehow. (I previously thought it was a CI issue, but just checked the file's blame log, and cannot find my change)

Since you caught this, would you be okay with altering your PR to flip the network type in vm.yaml? Would you see any reason not to start with a masquerade network type in lab1?

Well I can change that as well but I am not sure if that yaml is used anywhere where bridge network is required.

ansijain commented 3 years ago

/test kubevirt-io-presubmit-link-checker

ansijain commented 3 years ago

/retest

cwilkers commented 3 years ago

/lgtm /approve

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwilkers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/master/OWNERS)~~ [cwilkers] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cwilkers commented 3 years ago

/retest One more try, but I think we have a systemic issue with CI.