Closed tylerauerbeck closed 2 years ago
tylerauerbeck
commented
3 years ago @mazzystr @cwilkers I'm going to make an assumption (not having done all that much with Prow before) that this would go here: https://github.com/kubevirt/project-infra/blob/main/github/ci/prow-deploy/files/jobs/kubevirt/kubevirt.github.io/kubevirt-github-io-presubmits.yaml
Let me know if that makes sense and I can take a look at this (and potentially pull in #716 as well)
cwilkers
commented
3 years ago I'll admit ignorance to our CI process, but to my understanding, the kubevirt-github-io-presubmits.yaml you linked to runs rake, which takes its commands from the repo's Rakefile, not Makefile. Makefiles I understand. Rakefiles not so much.
mazzystr
commented
3 years ago Hi, yes we want that but not here. Take a look at the project-infra repo.
You'll find a presubmits job. Currently we only have make check_links in
the job. It would be awesome to also have the other check targets.
Rakefile is like Makefile for ruby apps. The default target does link checks also. We need to decouple that since it means we are checking links twice.
I'm down right now for a bit thanks to @cwilkers having me test a thing with SELinux. ;)
Happy to explain more tomorrow.
On Tue, Aug 31, 2021, 4:19 PM Chandler Wilkerson @.***> wrote:
I'll admit ignorance to our CI process, but to my understanding, the kubevirt-github-io-presubmits.yaml you linked to runs rake, which takes its commands from the repo's Rakefile, not Makefile. Makefiles I understand. Rakefiles not so much.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubevirt/kubevirt.github.io/issues/785#issuecomment-909721464, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS5KZZMOU4DV4ZRLKHPTQDT7VPOXANCNFSM5C4V4BEA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
tylerauerbeck
commented
3 years ago @mazzystr No problem. Happy to learn more about this and help add a few things here
kubevirt-bot
commented
2 years ago Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
kubevirt-bot
commented
2 years ago Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
kubevirt-bot
commented
2 years ago Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close
kubevirt-bot
commented
2 years ago @kubevirt-bot: Closing this issue.
Is this a BUG REPORT or FEATURE REQUEST?:
/kind enhancement
What happened:
In https://github.com/kubevirt/kubevirt.github.io/pull/719#discussion_r604195300, it was mentioned that the end goal is to run the following targets for each PR:
Right now (at least from what I can see), it doesn't appear that these are being run as part of the PR process.
What you expected to happen:
Automatic process on PR to run desired make targets
Anything else we need to know?:
@mazzystr I saw you had mentioned this in some of the closed PR's, so wanted to make sure this didn't get lost in the shuffle. I'm happy to work on this, but wanted to get some insight from you on how you envisioned this being implemented (GitHub actions, prow, etc.)