kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 112 forks source link

Delete duplicate and unused rancher logo #787

Closed tylerauerbeck closed 3 years ago

tylerauerbeck commented 3 years ago

What this PR does / why we need it:

Delete rancher.png as it is not used and causes issues with git on case-insensitive systems

Does this PR fix any issue? _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_:

Fixes #

Special notes for your reviewer:

When cloning this repo on OS X, I get the following warning:

warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'assets/images/adopters/RANCHER.png'
  'assets/images/adopters/rancher.png'

With a quick search, it appears only RANCHER.png is referenced:

╰─ grep -RHi "rancher.png" .
./_data/adopters.yml:    #   logo: RANCHER.png
kubevirt-bot commented 3 years ago

Hi @tylerauerbeck. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mazzystr commented 3 years ago

/ok-to-test

mazzystr commented 3 years ago

Thanks for the clean up.

We're probably going to remove both since SUSE purchased Rancher. The Rancher brand is likely to be dissolved. I have the logo sitting here as a place holder until we get further instructions.

/lgtm /approve

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mazzystr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/master/OWNERS)~~ [mazzystr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment