search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 112 forks source link

Added automatic detection of SELinux #789

Closed cwilkers closed 3 years ago

cwilkers commented 3 years ago

Signed-off-by: cwilkers cwilkers@redhat.com

Added the ability for the Makefile to automatically check SELinux enforcing status and set the SELINUX_ENABLED make variable accordingly.

New test only takes effect if SELINUX_ENABLED is not defined already, so it will not override a forced setting.

cwilkers commented 3 years ago

@cwilkers I have no review power here. But this LGTM and is how I see a lot of other projects do it as well.

Thanks @tylerauerbeck, @mazzystr is currently testing on his setup to make sure there aren't any unforeseen side effects.

mazzystr commented 3 years ago

As long as I run Permissive this patch will work for me.

Please a note added to README saying Linux on VirtualBox on Mac users will need to run SELinux Permissive mode until the vboxsf module bug is fixed.

/lgtm /approve

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mazzystr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/master/OWNERS)~~ [mazzystr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment