search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 112 forks source link

Adding Apple to list of adopters #794

Closed mazzystr closed 2 years ago

mazzystr commented 3 years ago

Signed-off-by: Chris Callegari mazzystr@gmail.com

Fixes #782

Special notes for your reviewer: @mlsorensen

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from mazzystr after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mazzystr commented 3 years ago

We can't. All the icons are governed by corporate legal/marketing. They're giving me the exact size in px on how they want the logo displayed.

On Tue, Sep 7, 2021 at 7:38 PM Tyler Auerbeck @.***> wrote:

@.**** commented on this pull request.

LGTM. Only thing I'd mention (and maybe something to look into in the future) would be normalizing the icon sizes. Right now they look a bit all over the place.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kubevirt/kubevirt.github.io/pull/794#pullrequestreview-748576001, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS5KZZORB6MZG6S6A6RD2TUA3EEDANCNFSM5DS7QCDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mazzystr commented 3 years ago

Preview link is here .... https://deploy-preview-794--kubevirtio.netlify.app/

kubevirt-bot commented 2 years ago

@mazzystr: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.