search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 112 forks source link

Fix istio post linting #796

Closed tylerauerbeck closed 2 years ago

tylerauerbeck commented 2 years ago

Signed-off-by: Tyler Auerbeck tauerbec@redhat.com

What this PR does / why we need it:

This fixes some issues found by the markdown linter in the istio blog post.

Does this PR fix any issue? _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_:

N/A

Special notes for your reviewer:

kubevirt-bot commented 2 years ago

Hi @tylerauerbeck. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mazzystr commented 2 years ago

/ok-to-test

On Thu, Sep 9, 2021, 8:54 PM kubevirt-bot @.***> wrote:

Hi @tylerauerbeck https://github.com/tylerauerbeck. Thanks for your PR.

I'm waiting for a kubevirt https://github.com/orgs/kubevirt/people member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org https://github.com/orgs/kubevirt/people to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here https://go.k8s.io/bot-commands?repo=kubevirt%2Fkubevirt.github.io.

Instructions for interacting with me using PR comments are available here https://git.k8s.io/community/contributors/guide/pull-requests.md. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue: repository.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kubevirt/kubevirt.github.io/pull/796#issuecomment-916609498, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS5KZ5ROD3222EX4XJEX63UBF6PBANCNFSM5DYPPIGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

tylerauerbeck commented 2 years ago

@mazzystr Looks like a broken link?

*  External link https://talks.godoc.org/github.com/jparrill/hands-on-prow/hands-on-prow.slide#1 failed: 500

A bit confused though because it seems to work fine for me.

mazzystr commented 2 years ago

@tylerauerbeck I'm good with removing the sentence that contains that link. 

$ git diff
diff --git a/_posts/2019-10-31-prow-jobs-for-kubevirt.markdown b/_posts/2019-10-31-prow-jobs-for-kubevirt.markdown
index 493efb37d..aac9ba72c 100644
--- a/_posts/2019-10-31-prow-jobs-for-kubevirt.markdown
+++ b/_posts/2019-10-31-prow-jobs-for-kubevirt.markdown
@@ -24,7 +24,7 @@ tags:

 General PR's, etc are tested by Prow to be validated to be reviewed by doing some sanity checks defined by developers.

-In general, the internals on how it works can be checked at [Life of a Prow Job](https://github.com/kubernetes/test-infra/blob/master/prow/life_of_a_prow_job.md), and of course in the presentation made by [Juanma](https://github.com/jparrill) on <https://talks.godoc.org/github.com/jparrill/hands-on-prow/hands-on-prow.slide#1>.
+In general, the internals on how it works can be checked at [Life of a Prow Job](https://github.com/kubernetes/test-infra/blob/master/prow/life_of_a_prow_job.md).
mazzystr commented 2 years ago

/lgtm /approve

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mazzystr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/master/OWNERS)~~ [mazzystr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment