search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 112 forks source link

Adding Kubevirt Summit playlist #804

Closed ansijain closed 2 years ago

ansijain commented 2 years ago

Signed-off-by: ansijain ansi.jain@india.nec.com

What this PR does / why we need it: Adding Kubevirt Summit playlist to videos section.

Does this PR fix any issue? _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_:

Fixes #802

Special notes for your reviewer:

kubevirt-bot commented 2 years ago

Hi @ansijain. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mazzystr commented 2 years ago

/ok-to-test

mazzystr commented 2 years ago

@ansijain Do you think you can make the page a template that sources a data file? See index.html and adopters.yml

ansijain commented 2 years ago

@ansijain Do you think you can make the page a template that sources a data file? See index.html and adopters.yml

Well yes. I have added a new commit regarding this. Please check

ansijain commented 2 years ago

/retest

mazzystr commented 2 years ago

I fixed a couple problems so we could get moving along. That target repo updated their main branch and broke our link. The link checker checks production website for new urls. That creates a chicken/egg scenario with new website urls. I just set to ignore. We can remove the ignore in the future.

The new addition looks great otherwise! Thanks!

/lgtm /approve

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mazzystr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/master/OWNERS)~~ [mazzystr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment