Closed mazzystr closed 2 years ago
@mazzystr: The label(s) `/label website
` cannot be applied. These labels are supported: ``
@zhlhahaha Url for review for logo use compliance is here .... https://deploy-preview-815--kubevirtio.netlify.app/
Please comment lgtm and approve.
Then I will have a maintainer add the merge tag. Thanks!
@zhlhahaha Url for review for logo use compliance is here .... https://deploy-preview-815--kubevirtio.netlify.app/
Please comment lgtm and approve.
Then I will have a maintainer add the merge tag. Thanks!
Ok, would it be better to put the source of Arm logo in the comments?
Source of the logo was from the arm corp logo usage page.
Usually I copy the img with the website code. Then the img is served by GitHub Pages. There have been complaints in the past that our website adds undue bandwidth load on customers' servers.
On Sun, Nov 7, 2021 at 11:52 PM zhlhahaha @.***> wrote:
@zhlhahaha https://github.com/zhlhahaha Url for review for logo use compliance is here .... https://deploy-preview-815--kubevirtio.netlify.app/
Please comment lgtm and approve.
Then I will have a maintainer add the merge tag. Thanks!
Ok, would it be better to put the source of Arm logo in the comments?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubevirt/kubevirt.github.io/pull/815#issuecomment-962894192, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS5KZ3IMDC3WAEYZDT3CJLUK56UHANCNFSM5HMSWK4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Ok, /approve /lgtm
Thank you!
/lgtm /approve
On Mon, Nov 8, 2021, 5:25 PM kubevirt-bot @.***> wrote:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: zhlhahaha https://github.com/kubevirt/kubevirt.github.io/pull/815#issuecomment-963728049 To complete the pull request process https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process, please ask for approval from mazzystr after the PR has been reviewed.
The full list of commands accepted by this bot can be found here https://go.k8s.io/bot-commands?repo=kubevirt%2Fkubevirt.github.io. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubevirt/kubevirt.github.io/pull/815#issuecomment-963728299, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS5KZ3LSNBBBHJUP4247OTULBZ67ANCNFSM5HMSWK4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
@mazzystr: you cannot LGTM your own PR.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mazzystr, zhlhahaha
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/kind enhancement /label website
What this PR does / why we need it: Adding arm to index page as end-user per KubeVirt ADOPTERS
Fixes #812