Closed Hiiirad closed 2 years ago
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:
Hi @Hiiirad. Thanks for your PR.
I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test /assign @jberkus
@Hiiirad Thank you for the PR (and the good news!) Could you amend your commit with a signoff and repush?
@Hiiirad Thank you for the PR (and the good news!) Could you amend your commit with a signoff and repush?
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To complete the pull request process, please ask for approval from jberkus after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
Changed Sandbox to Incubating :)
What this PR does / why we need it:
Does this PR fix any issue? _(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged)_:Special notes for your reviewer: