search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
29 stars 110 forks source link

Change Sandbox to Incubating in footer.html #834

Closed Hiiirad closed 2 years ago

Hiiirad commented 2 years ago

What this PR does / why we need it:

Does this PR fix any issue? _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_:

Fixes #

Special notes for your reviewer:

kubevirt-bot commented 2 years ago

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kubevirt-bot commented 2 years ago

Hi @Hiiirad. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign cwilkers after the PR has been reviewed. You can assign the PR to them by writing /assign @cwilkers in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jobbler commented 2 years ago

/lgtm Checked the preview. Thanks for updating this.

mazzystr commented 2 years ago

@Hiiirad Can you please rebase and create the commit with the git -s arg? That adds your signature to the commit message and allows CI to pass the dco check. Thanks!

mazzystr commented 2 years ago

/ok-to-test

Hiiirad commented 2 years ago

@Hiiirad Can you please rebase and create the commit with the git -s arg? That adds your signature to the commit message and allows CI to pass the dco check. Thanks!

I did sign the commit with git commit -S command. I don't know why this happened. Do you want me to close this PR and do it again?

mazzystr commented 2 years ago

DCO can really be a pain in the butt. I'm not sure why it isn't picking up on your signature.

Try recreating the PR. Make sure your commit log looks like this... https://github.com/kubevirt/user-guide#sign-your-commits ... before creating the pull request.