search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
29 stars 110 forks source link

Update quickstart_cloud.md #836

Closed serewicz closed 2 years ago

serewicz commented 2 years ago

If someone does a copy and paste too fast there is no output. It takes a bit for the deployment to be running in order to see output.

What this PR does / why we need it:

Does this PR fix any issue? _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_:

Fixes #

Special notes for your reviewer: Tried this once already. Didn't see it go through. Trying a second time.

kubevirt-bot commented 2 years ago

Hi @serewicz. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
serewicz commented 2 years ago

/assign @davidvossel

serewicz commented 2 years ago

Hello,

How do I add the DCO signoff now that I already did the commit. Should I revoke the commit and do something else?

jobbler commented 2 years ago

I checked the preview and this looks good to me /lgtm

serewicz commented 2 years ago

Hello, Sorry to be a total newb, but when I click on the "Details" link on the dco it throws a 404 error. Advice on adding the dco appreciated. What else should I be doing for this? Thanks.

jobbler commented 2 years ago

@serewicz You need to sign your commits. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Since you already committed this one, you should be ablt to ammend it. git commit -S --ammend

I got this command from https://superuser.com/questions/397149/can-you-gpg-sign-old-commits

kubevirt-bot commented 2 years ago

New changes are detected. LGTM label has been removed.

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from davidvossel after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 2 years ago

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).