kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
29 stars 110 forks source link

Windows 11 installation blog post #839

Closed jean-edouard closed 1 year ago

jean-edouard commented 2 years ago

What this PR does / why we need it: This is a first attempt at documenting Windows 11 installation. There's a probably a lot to improve, in both the format and the content, so please don't hold back in your review!

Special notes for your reviewer:

mazzystr commented 2 years ago

Looks good to me at glance

/lgtm

@jobbler Do you have time to roll through this with a deeper check?

fossedihelm commented 2 years ago

Thanks @jean-edouard It looks brilliant! How about adding a note specifying that tpm, smm and secureBoot are required for Windows 11? Do you think it will be out of scope? Thanks

jean-edouard commented 2 years ago

Thanks @jean-edouard It looks brilliant! How about adding a note specifying that tpm, smm and secureBoot are required for Windows 11? Do you think it will be out of scope? Thanks

Good idea, thank you! I just added a note about it, updated the date to next Monday and force-pushed.

fossedihelm commented 2 years ago

Thanks @jean-edouard It looks brilliant! How about adding a note specifying that tpm, smm and secureBoot are required for Windows 11? Do you think it will be out of scope? Thanks

Good idea, thank you! I just added a note about it, updated the date to next Monday and force-pushed.

@jean-edouard Thanks! /lgtm

aburdenthehand commented 2 years ago

@jean-edouard - Looks like this was approved a while ago but never merged. Did you want to update the date again and we can tag an approver to get this merged?

stu-gott commented 1 year ago

/approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stu-gott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/main/OWNERS)~~ [stu-gott] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment